Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hir::CrateItem. #83684

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Remove hir::CrateItem. #83684

merged 2 commits into from
Mar 31, 2021

Conversation

cjgillot
Copy link
Contributor

The crate span is exactly the crate module's inner span. There is no need to store it twice.

@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

r=me with ui-fulldeps tests updated.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2021
@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Mar 31, 2021

📌 Commit fbfef40 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2021
flip1995
flip1995 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy changes LGTM

@bors
Copy link
Contributor

bors commented Mar 31, 2021

⌛ Testing commit fbfef40 with merge a5029ac...

@bors
Copy link
Contributor

bors commented Mar 31, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing a5029ac to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2021
@bors bors merged commit a5029ac into rust-lang:master Mar 31, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 31, 2021
@cjgillot cjgillot deleted the csp branch March 31, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cjgillot @rust-highfive @rust-log-analyzer @petrochenkov @bors @flip1995 @rustbot