-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix perf regression in rustdoc::bare_urls #84034
Conversation
Before, this was compiling the regex on every single item in the crate. This would have been caught by `clippy::declare_interior_mutable_const`.
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 8c7b7dd with merge 47a47f0f8ba775de36a751857867bfbea8310770... |
r=me presuming perf looks good |
☀️ Try build successful - checks-actions |
Queued 47a47f0f8ba775de36a751857867bfbea8310770 with parent bc66b92, future comparison URL. |
Finished benchmarking try commit (47a47f0f8ba775de36a751857867bfbea8310770): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Yup, that was it. @bors r=Mark-Simulacrum rollup=never |
📌 Commit 8c7b7dd has been approved by |
☀️ Test successful - checks-actions |
This regressed in #81764. After that PR, rustdoc compiled the regex for every single item in the crate: https://perf.rust-lang.org/compare.html?start=125505306744a0a5bb01d62337260a95d9ff8d57&end=2e495d2e845cf27740e3665f718acfd3aa17253e&stat=instructions%3Au
This would have been caught by
clippy::declare_interior_mutable_const
(cc #77983).