Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more pat2021 tests #84185

Merged
merged 3 commits into from
Apr 15, 2021
Merged

add more pat2021 tests #84185

merged 3 commits into from
Apr 15, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Apr 14, 2021 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2021
nikomatsakis
nikomatsakis requested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I would like is a test macro-pat-pattern-followed-by-or-in-2021.rs that uses // edition: 2021 and which has $x:pat | and shows that we get an error (and probably one without the edition that does not...)

@Rustin170506 Rustin170506 changed the title add macro-or-patterns-2021 test add more pat2021 tests Apr 14, 2021
@Rustin170506
Copy link
Member Author

@nikomatsakis How about now?

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 14, 2021

📌 Commit eb944c1 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2021
@Rustin170506
Copy link
Member Author

@nikomatsakis Thanks for your review.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 14, 2021
@Dylan-DPC
Rollup merge of rust-lang#84185 - hi-rustin:rustin-patch-macro, r=nik…
01b03f7 
…omatsakis

add more pat2021 tests

close rust-lang#84138

r? `@nikomatsakis`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 14, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 14, 2021
@Dylan-DPC
Rollup merge of rust-lang#84185 - hi-rustin:rustin-patch-macro, r=nik…
9e8daf3 
…omatsakis

add more pat2021 tests

close rust-lang#84138

r? ``@nikomatsakis``
This was referenced Apr 14, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2021
@bors
Auto merge of rust-lang#84206 - Dylan-DPC:rollup-knl2jgq, r=Dylan-DPC
9c3b66c 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#82492 (Move `std::sys_common::alloc` to new module `std::sys::common`)
 - rust-lang#84177 (Fix join_paths error display.)
 - rust-lang#84185 (add more pat2021 tests)
 - rust-lang#84191 (Update books)
 - rust-lang#84192 (Fix typos in rustc_codegen_ssa/src/back/write.rs.)
 - rust-lang#84196 (:arrow_up: rust-analyzer)
 - rust-lang#84201 (rustdoc: Note that forbidding anchors in links to primitives is a bug)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 13effcb into rust-lang:master Apr 15, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

disallow | from the follow-set of pat2021
5 participants
@Rustin170506 @nikomatsakis @bors @rust-highfive @rustbot