-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark evaluate_obligation
query as eval_always
#84280
Mark evaluate_obligation
query as eval_always
#84280
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 0ce8894 with merge 32335f293d89c15a45f219a1a85520d712f00b3b... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
// FIXME(#83538): This queery shouldm't be influenced by any untracked | ||
// blobal state, but it currently is. We use `eval_aways` to prevent this | ||
// from causing ICEs - when the underlying issue is fixed, the `eval_always` | ||
// modifier should be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment full of typos :-(
☀️ Try build successful - checks-actions |
Queued 32335f293d89c15a45f219a1a85520d712f00b3b with parent bd9949b, future comparison URL. |
Finished benchmarking try commit (32335f293d89c15a45f219a1a85520d712f00b3b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@Aaron1011 Ping from triage, CI is still red here. |
The underlying issues have been fixed, so this is no longer needed. |
No description provided.