Deduplicate ParamCandidates with the same value except for bound vars #84559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
added
the
WG-traits
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
requested changes
Apr 30, 2021
| // the same except for unused bound vars. Just pick the current one (the should | ||
| // both evaluate to the same answer). This is probably best characterized as a | ||
| // "hack", since we might prefer to just do our best to *not* create essentially | ||
| // duplicate candidates in the first place. |
There was a problem hiding this comment.
maybe we want to pick the one with fewer bound vars? it'd be nice to be more deterministic here
pietroalbini
added
beta-nominated
|
This fixes a regression that slipped into beta 1.53, nominating for backport. |
|
Status on this: discussed with @nikomatsakis a change he'd like to see here. Just have to get some time to implement it. |
jackh726
added
S-waiting-on-author
|
@bors r+ |
|
📌 Commit c1ef0f3 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never p=1 we want this into master and backported soon, but I also want perf individually on it (no need to prerun) |
rustbot
added
the
beta-accepted
Merged
Mark-Simulacrum
removed
the
beta-nominated
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2021
…ulacrum [beta] backports First-ish round of beta backports: * [beta] backport for rust-lang#84769 rust-lang#84969 * [beta] Bump stage0 to production 1.52.0 rust-lang#84994 * Deduplicate ParamCandidates with the same value except for bound vars rust-lang#84559
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84398
This is kind of a hack. I wonder if we can get other types of candidates that are the same except for bound vars. This won't be a problem with Chalk, since we don't really need to know that there are two different "candidates" if they both give the same final substitution.
r? @nikomatsakis