Enforce rustdoc-gui test-suite run

[GuillaumeGomez]

Part of #84550

[jyn514]

By the way, Is there something else to do alongside this to be sure that the rustdoc-gui test-suite will be run on linux targets?

Yes, make sure nodejs and npm are installed on those builders. You can check by looking at the build logs for x86_64-gnu-llvm-10 and making sure rustdoc-gui isn't skipped.

[GuillaumeGomez]

Well, I guess now I have to add it in multiple places then. :3

[Mark-Simulacrum]

Why are we putting this check on the PR builder? I understand conceptually that it's nice to get breakage early, but I worry that we shouldn't just add onto that builder without consideration. It may be worthwhile to take the approach of the tools builder, where we only run it directly on PRs with modification to the tools directory (while bors full builds always run it), and move the check from the aux builder to the tools builder.

[jyn514]

It may be worthwhile to take the approach of the tools builder, where we only run it directly on PRs with modification to the tools directory (while bors full builds always run it), and move the check from the aux builder to the tools builder.

Changes to rustdoc almost never modify the tools directory, so that means this check won't run on PRs.

[Mark-Simulacrum]

Sure, we can add rustdoc to the list of things which trigger a build?

[GuillaumeGomez]

Sure, we can add rustdoc to the list of things which trigger a build?

Just to be sure: it's something to do on "infra side", not in this PR, right?

[jyn514]

@GuillaumeGomez no, it should go in this PR. You should find where x86_64-gnu-tools determines if the check should be skipped and modify it to take src/librustdoc into account.

[GuillaumeGomez]

I see, thanks for the clarification.

[jyn514]

Is npm not available through apt?

[GuillaumeGomez]

Apparently not based on the previous error.

[GuillaumeGomez]

Another thing to be noted: if the browser-ui-test package isn't installed, we skip the rustdoc-gui tests. Should I also add the installation of this package in the Dockerfile I updated so the tests are run?

[jyn514]

if the browser-ui-test package isn't installed, we skip the rustdoc-gui tests

I thought you changed it to give a hard error? If not, can you do that now?

[GuillaumeGomez]

No, I only enforced the presence of npm. Adding it.

[GuillaumeGomez]

@Mark-Simulacrum Updated!

[GuillaumeGomez]

@Mark-Simulacrum Seems like the CI wasn't run on rustdoc-GUI...

EDIT: i was tired, it's normal because there is no rustdoc or rustdoc-GUI changes. So all normal. Waiting for @Mark-Simulacrum final review then I guess. :)

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit 5358498 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 5358498 with merge 2023cc3...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 2023cc3 to master...