Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize vec_extend_from_within #84642

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Stabilize vec_extend_from_within #84642

merged 1 commit into from
Apr 28, 2021

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Apr 28, 2021

Closes #81656

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2021
dtolnay
dtolnay approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dtolnay
Copy link
Member

dtolnay commented Apr 28, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Apr 28, 2021

📌 Commit 2bcf931d3c7eb7895adff9a4c99f7c71aac763dd has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Amanieu Amanieu force-pushed the vec_extend_from_within branch from 2bcf931 to 22951b7 Compare April 28, 2021 06:27
@Amanieu
Copy link
Member Author

Amanieu commented Apr 28, 2021

@bors r=dtolnay

@bors
Copy link
Contributor

bors commented Apr 28, 2021

📌 Commit 22951b7 has been approved by dtolnay

@JohnTitor JohnTitor mentioned this pull request Apr 28, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2021
@bors
Auto merge of rust-lang#84644 - JohnTitor:rollup-nzq9rjz, r=JohnTitor
76a04dd 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#84529 (Improve coverage spans for chained function calls)
 - rust-lang#84616 (Fix empty dom toggle)
 - rust-lang#84622 (Make traits with GATs not object safe)
 - rust-lang#84624 (Make sentence in env::args_os' docs plain and simple)
 - rust-lang#84642 (Stabilize vec_extend_from_within)

Failed merges:

 - rust-lang#84636 (rustdoc: change aliases attribute to data-aliases)

r? `@ghost`
`@rustbot` modify labels: rollup
@paolobarbolini paolobarbolini mentioned this pull request Apr 28, 2021
Closed
@bors bors merged commit 7ebe5b9 into rust-lang:master Apr 28, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 28, 2021
@johndpierre1 johndpierre1 mentioned this pull request Sep 9, 2024
Closed
3 tasks
johndpierre1
johndpierre1 reviewed Sep 9, 2024
View reviewed changes
Copy link

@johndpierre1 johndpierre1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#84642

johndpierre1
johndpierre1 reviewed Sep 9, 2024
View reviewed changes
Copy link

@johndpierre1 johndpierre1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.0

@aDotInTheVoid aDotInTheVoid mentioned this pull request Dec 13, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndpierre1 johndpierre1 johndpierre1 left review comments

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for vec_extend_from_within
7 participants
@Amanieu @rust-highfive @dtolnay @bors @rust-log-analyzer @johndpierre1 @rustbot