-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .name_str() to format primitive types in error messages #85187
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
fn foo(length: &u32) -> i32 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Maybe add a short comment here on what this test is for? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
0 | ||
} | ||
|
||
fn bar(length: &f32) -> f64 { | ||
0.0 | ||
} | ||
|
||
fn main() { | ||
let mut length = 0; | ||
length = { foo(&length) }; | ||
//~^ ERROR mismatched types [E0308] | ||
length = foo(&length); | ||
//~^ ERROR mismatched types [E0308] | ||
|
||
let mut float_length = 0.0; | ||
float_length = { bar(&float_length) }; | ||
//~^ ERROR mismatched types [E0308] | ||
float_length = bar(&float_length); | ||
//~^ ERROR mismatched types [E0308] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
error[E0308]: mismatched types | ||
--> $DIR/issue-84976.rs:11:16 | ||
| | ||
LL | length = { foo(&length) }; | ||
| ^^^^^^^^^^^^ expected `u32`, found `i32` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/issue-84976.rs:13:14 | ||
| | ||
LL | length = foo(&length); | ||
| ^^^^^^^^^^^^ expected `u32`, found `i32` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/issue-84976.rs:17:22 | ||
| | ||
LL | float_length = { bar(&float_length) }; | ||
| ^^^^^^^^^^^^^^^^^^ expected `f32`, found `f64` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/issue-84976.rs:19:20 | ||
| | ||
LL | float_length = bar(&float_length); | ||
| ^^^^^^^^^^^^^^^^^^ expected `f32`, found `f64` | ||
|
||
error: aborting due to 4 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0308`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the
Display
output not just call writeu32
/i32
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, that's fine. That's what I would expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no
Display
implementation forIntType
,UintType
etc., only a derivedDebug
implementation that causes the wrong formatting observed in #84976 (U32
instead ofu32
etc.).