Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make const_generics_defaults not an incomplete feature #85251

Merged
merged 2 commits into from
May 18, 2021
Merged

Make const_generics_defaults not an incomplete feature #85251

merged 2 commits into from
May 18, 2021

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented May 13, 2021

r? @lcnr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr
Copy link
Contributor

lcnr commented May 18, 2021 •
edited
Loading

cc @rust-lang/project-const-generics

with the min_const_generics hack not allowing generic params in const param defaults this feature already seems quite good to me. It still has some open issues with full const_generics, but that feature already has an incomplete_feature warning itself

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 18, 2021

📌 Commit aec611c has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2021
@RalfJung RalfJung mentioned this pull request May 18, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2021
@bors
Auto merge of rust-lang#85443 - RalfJung:rollup-d9gd64t, r=RalfJung
491cf55 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#84462 (rustdoc: use focus for search navigation)
 - rust-lang#85251 (Make `const_generics_defaults` not an incomplete feature)
 - rust-lang#85404 (Backport 1.52.1 release notes)
 - rust-lang#85407 (Improve display for "copy-path" button, making it more discreet)
 - rust-lang#85423 (Don't require cmake on Windows when LLVM isn't being built)
 - rust-lang#85428 (Add x.py pre-setup instructions)
 - rust-lang#85442 (fix typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aa10380 into rust-lang:master May 18, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 18, 2021
@lcnr lcnr added the A-const-generics Area: const generics (parameters and arguments) label Dec 11, 2021
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
A-const-generics Area: const generics (parameters and arguments) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BoxyUwU @rust-log-analyzer @lcnr @bors @rust-highfive @rustbot