CTFE validation: handle pointers in str #85332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
May 15, 2021
| | | ||
| = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior. | ||
| = note: the raw bytes of the constant (size: 16, align: 8) { | ||
| ╾───────alloc3────────╼ 01 00 00 00 00 00 00 00 │ ╾──────╼........ |
There was a problem hiding this comment.
Yeah it's quite nice. ;) Though in this case, the error is behind a ptr indirection, so you cannot see it here.
|
@bors r+ |
|
📌 Commit f1fdbe2 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r- you need to make the test emit output for each bitwidth |
bors
added
S-waiting-on-author
|
Argh that's painful. :( |
|
@bors r=oli-obk |
|
📌 Commit 8af76cb has been approved by |
bors
added
S-waiting-on-bors
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 8af76cb has been approved by |
This comment has been minimized.
This comment has been minimized.
|
@bors r- |
bors
added
S-waiting-on-author
|
@bors r=oli-obk |
|
📌 Commit 70c1cf1 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also finally learned how I can match some NOTEs in a ui test without matching all of them, and applied that to some const tests in the 2nd commit where I added NOTE because I did not know what I was doing. I can separate this into its own PR if you prefer.
Fixes #83182
r? @oli-obk