Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc aliases to unit #85334

Merged
merged 1 commit into from
May 23, 2021
Merged

Add doc aliases to unit #85334

merged 1 commit into from
May 23, 2021

Conversation

wooster0
Copy link
Contributor

I think it makes sense for unit to have the same doc aliases as tuple does.

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2021
dtolnay
dtolnay approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented May 22, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 22, 2021

📌 Commit 10c43c3 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 23, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2021
@bors
Auto merge of rust-lang#85594 - Dylan-DPC:rollup-40sgqgg, r=Dylan-DPC
92418ce 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#84758 (MSVC: Avoid using jmp stubs for dll function imports)
 - rust-lang#85288 (add an example to explain std::io::Read::read returning 0 in some cases)
 - rust-lang#85334 (Add doc aliases to `unit`)
 - rust-lang#85525 (Fix my mailmap entry)
 - rust-lang#85571 (Remove surplus prepend LinkedList fn)
 - rust-lang#85575 (Fix auto-hide for implementations and implementors.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4430aab into rust-lang:master May 23, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 23, 2021
@wooster0 wooster0 deleted the patch-8 branch September 24, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wooster0 @rust-highfive @dtolnay @bors @rustbot