Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug info tests for range, fix-sized array, and cell types #85448

Merged
merged 1 commit into from
Jun 27, 2021
Merged

Add debug info tests for range, fix-sized array, and cell types #85448

merged 1 commit into from
Jun 27, 2021

Conversation

nanguye2496
Copy link

This PR add several debug info tests to guarantee that the displays of fixed sized arrays, range types, cell types, threads, locks, and mutexes in CDB are correct.

It also updates CDB tests for slices in pretty-std.rs after string visualization in WinDbg is fixed by this PR: #81898.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2021
@nanguye2496
Copy link
Author

@Mark-Simulacrum: I think my previous PR was closed automatically when I mistakenly reset all of my changes.

@nanguye2496
Copy link
Author

@Mark-Simulacrum: I think my previous PR was closed automatically when I mistakenly reset all of my changes.

Hi Mark, I wonder if you've had a chance to look at my tests?

@Mark-Simulacrum
Copy link
Member

Review usually takes more than just a couple days -- can you link to the previous PR, to help me find it?

@nanguye2496
Copy link
Author

Review usually takes more than just a couple days -- can you link to the previous PR, to help me find it?

Here is the link to the closed PR: #85420.
It was not my intention to rush you. I just want to keep our conversation on this PR going.

@nanguye2496
Copy link
Author

@Mark-Simulacrum: Hi Mark, I wonder if you have had a chance to have a closer look at this PR?

@Mark-Simulacrum
Copy link
Member

It's in my queue; it'll likely be a bit before I or someone else gets to it. Sorry for the wait.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented May 26, 2021

📌 Commit 903212d550ebc7e293c8da0e14fbc3d06cbf5813 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2021
@bors
Copy link
Contributor

bors commented May 26, 2021

⌛ Testing commit 903212d550ebc7e293c8da0e14fbc3d06cbf5813 with merge d244ad585a815e19544d76b6acc32fbb2530f45a...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 26, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2021
@Mark-Simulacrum
Copy link
Member

@bors retry isl download failed

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2021
@bors
Copy link
Contributor

bors commented May 30, 2021

⌛ Testing commit 903212d550ebc7e293c8da0e14fbc3d06cbf5813 with merge d1c87ca0e5695d556e3cc95fe6abf847562caa5f...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 30, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 30, 2021
@nanguye2496
Copy link
Author

nanguye2496 commented May 31, 2021 •
edited
Loading

💔 Test failed - checks-actions

@Mark-Simulacrum : Hi Mark, I think this error is caused because the offsets for the second field of RefCell and RefMut in x64 and x86 are different. Is there anyway for me to provide separate expected outputs for two different architectures? For now, I just made the offset a wildcard, but if there is a better way to accommodate different architectures, please let me know,

@nanguye2496
Copy link
Author

@Mark-Simulacrum: I've made some changes to address the build failures. Would you mind having another look?

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2021
@nanguye2496 nanguye2496 force-pushed the nanguye2496/debuginfo_tests branch 2 times, most recently from 4232b9d to 04f276d Compare June 25, 2021 20:50
@nanguye2496
Copy link
Author

@Mark-Simulacrum : I fixed the test failures. Please have a look.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Jun 27, 2021

📌 Commit 0d917a6 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2021
@bors
Copy link
Contributor

bors commented Jun 27, 2021

⌛ Testing commit 0d917a6 with merge d6f694c9ae1a549ee9c8c14cb6c7c3a23dc75bf9...

@bors
Copy link
Contributor

bors commented Jun 27, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 27, 2021
@JohnTitor
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2021
@bors
Copy link
Contributor

bors commented Jun 27, 2021

⌛ Testing commit 0d917a6 with merge 543ab99...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jun 27, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 543ab99 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2021
@bors bors merged commit 543ab99 into rust-lang:master Jun 27, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 27, 2021
@bors bors mentioned this pull request Jun 27, 2021
Merged
@petrochenkov petrochenkov mentioned this pull request Nov 28, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2021
@matthiaskrgr
Rollup merge of rust-lang#91317 - petrochenkov:debugnu, r=Mark-Simula…
0e2e63a 
…crum

tests: Ignore `test/debuginfo/rc_arc.rs` on windows-gnu

The tests checks some pretty-printer output, but pretty-printers are not embedded on windows-gnu.

Regressed in rust-lang#85448.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 30, 2021
@matthiaskrgr
Rollup merge of rust-lang#91317 - petrochenkov:debugnu, r=Mark-Simula…
da7612c 
…crum

tests: Ignore `test/debuginfo/rc_arc.rs` on windows-gnu

The tests checks some pretty-printer output, but pretty-printers are not embedded on windows-gnu.

Regressed in rust-lang#85448.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 30, 2021
@JohnTitor
Rollup merge of rust-lang#91317 - petrochenkov:debugnu, r=Mark-Simula…
ae1badb 
…crum

tests: Ignore `test/debuginfo/rc_arc.rs` on windows-gnu

The tests checks some pretty-printer output, but pretty-printers are not embedded on windows-gnu.

Regressed in rust-lang#85448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
9 participants
@nanguye2496 @rust-highfive @Mark-Simulacrum @bors @rust-log-analyzer @JohnTitor @nnguyen2496 @rustbot @nanguye