Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[cfg(bootstrap)] out NoneError and other v1 try_trait stuff #85482

Merged
merged 1 commit into from
May 21, 2021
Merged

#[cfg(bootstrap)] out NoneError and other v1 try_trait stuff #85482

merged 1 commit into from
May 21, 2021

Conversation

scottmcm
Copy link
Member

Closes #46871

r? @yaahc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2021
@yaahc
Copy link
Member

yaahc commented May 19, 2021 •
edited
Loading

sick, was confused for a bit then I realized I missed a PR, #84767

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc
Copy link
Member

yaahc commented May 20, 2021

shippit?

@bors r+

@bors
Copy link
Contributor

bors commented May 20, 2021

📌 Commit 58a85d5 has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2021
@bors
Copy link
Contributor

bors commented May 21, 2021

⌛ Testing commit 58a85d5 with merge af2ed1b...

@bors
Copy link
Contributor

bors commented May 21, 2021

☀️ Test successful - checks-actions
Approved by: yaahc
Pushing af2ed1b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 21, 2021
@bors bors merged commit af2ed1b into rust-lang:master May 21, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 21, 2021
@jonas-schievink jonas-schievink mentioned this pull request May 23, 2021
Closed
gabrik added a commit to eclipse-fog05/fog05 that referenced this pull request May 26, 2021
@gabrik
fix issue, updating to be compatible with: rust-lang/rust#85482
9a1acee 
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
@chokoboko chokoboko mentioned this pull request May 27, 2021
Closed
@sempervictus sempervictus mentioned this pull request Jul 22, 2021
Closed
@sggutier sggutier mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yaahc yaahc

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

why havn't implemented Error trait for std::option::NoneError ?
6 participants
@scottmcm @yaahc @rust-log-analyzer @bors @rust-highfive @rustbot