Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the "IP" feature (continued from #76098) #85585

Closed
wants to merge 24 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
02e835a
stabilize the "ip" feature and document stability guarantees
little-dude Nov 20, 2019
7b7ca5d
std::net: add Ipv6Multicastscope variants
little-dude Jan 12, 2020
f33f945
Update feature gates
caass Sep 4, 2020
86e9b37
Apply suggestions from code review
caass Sep 4, 2020
f91cb14
`is_unicast_link_local_strict` --> `is_unicast_link_local`
caass Sep 4, 2020
259ada1
Add checking for ipv4-(mapped | compatible) addresses
caass Sep 4, 2020
f15098f
Add stability attributes to Ipv6MulticastScope
caass Sep 4, 2020
c8ca757
remove `/// #![feature(ip)]` tags from doc tests
caass Sep 4, 2020
392a21b
Remove some more #![feature(ip)] stuff
caass Sep 4, 2020
f5694dc
Remove some code having to do with link-local strict
caass Sep 4, 2020
8de3caf
Change checks for is_unicast_link_local_strict to is_unicast_link_local
caass Oct 6, 2020
f224551
Rewrite ipv4 checks to check ipv6 stuff first
caass Oct 6, 2020
2db2b5d
Fix test cases that checked for relaxed behavior
caass Oct 7, 2020
c72ea14
Restore the relaxed behavior of `is_unicast_link_local`
caass Oct 21, 2020
179d376
Revert "Fix test cases that checked for relaxed behavior"
caass Oct 21, 2020
4f77918
Remove IP feature gate
caass Oct 21, 2020
2f1078d
Remove duplicate UI tests as per @CDirkx's suggestions
caass Nov 24, 2020
0348e5e
Rewrite using new rustdoc comments!!!!
caass Nov 24, 2020
36792e8
Adjust Ipv4-in-Ipv6 checking to ignore Ipv4-compatible addresses
caass Nov 25, 2020
42b9a38
Revert "Adjust Ipv4-in-Ipv6 checking to ignore Ipv4-compatible addres…
caass Nov 25, 2020
e6b76f0
Update doc comments
caass Nov 25, 2020
f469444
stop treating `::ffff:0.0.0.0` as unspecified
caass Feb 6, 2021
240a913
wow i hope i didn't mess something up
caass Feb 28, 2021
6c42f4a
Fix tests
saethlin May 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Fix test cases that checked for relaxed behavior"
This reverts commit e0f66e43da61d8fe8aadc6bcdc2545de51607332.
  • Loading branch information
caass authored and saethlin committed May 22, 2021

Unverified

The committer email address is not verified.
commit 179d37680c87600b46ca4404b831b6543ddf562e
24 changes: 7 additions & 17 deletions library/std/src/net/ip/tests.rs
Original file line number Diff line number Diff line change
@@ -302,14 +302,8 @@ fn ip_properties() {
check!("1::", global);
check!("fc00::");
check!("fdff:ffff::");

// see [`is_unicast_link_local`]
// fe80:ffff:: is *not* unicast_link_local
check!("fe80:ffff::", global);
// fe80:: *is* unicast_link_local
check!("fe80::");

check!("febf:ffff::", global);
check!("fe80:ffff::");
check!("febf:ffff::");
check!("fec0::", global);
check!("ff01::", multicast);
check!("ff02::", multicast);
@@ -617,30 +611,26 @@ fn ipv6_properties() {
check!(
"fe80:ffff::",
&[0xfe, 0x80, 0xff, 0xff, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
global | unicast_global
unicast_link_local
);

check!("fe80::", &[0xfe, 0x80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], unicast_link_local);

check!(
"febf:ffff::",
&[0xfe, 0xbf, 0xff, 0xff, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
global | unicast_global
unicast_link_local
);

check!(
"febf::",
&[0xfe, 0xbf, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
global | unicast_global
);
check!("febf::", &[0xfe, 0xbf, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], unicast_link_local);

check!(
"febf:ffff:ffff:ffff:ffff:ffff:ffff:ffff",
&[
0xfe, 0xbf, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
0xff, 0xff
],
global | unicast_global
unicast_link_local
);

check!(
@@ -655,7 +645,7 @@ fn ipv6_properties() {
check!(
"fe80:0:0:1::",
&[0xfe, 0x80, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0],
global | unicast_global
unicast_link_local
);

check!(