Prepare bootstrapping priv-by-default struct fields

[alexcrichton]

It seemed that the general consensus in #8122 was that struct fields should be private by default.

I had the brilliant idea to forbid pub on struct fields, so right now this change can't bootstrap. To get around this, I'm modifying it such that the next snapshot compiler will completely disregard all visibility qualifiers on fields of structs. That way after the next snapshot I can rampage through and swap out all the pub/priv qualifiers.

After this there's only one use-case of priv, and that's just making enum variants private in an otherwise public enum. I feel like this could be emulated with other semantics, just not as nicely, but regardless I think that struct fields should be private by default.

[graydon]

Oh hmn I don't think this got anywhere close to broad consensus. It's a pretty broad change and I ... am not sure I'm into it. Modules do decent privacy control already and I'd hate to push people towards writing get/set methods everywhere when a simple field access will do.

[alexcrichton]

Oh sure, closing this because it's better discussed in the issue rather than on a pull request.