fix rustdoc stack overflow on mutually recursive Deref #86322
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ollie27 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
src/librustdoc/html/render/mod.rs
Outdated
| target_impls, | ||
| already_seen, | ||
| ); | ||
| } | ||
| } | ||
| } |
src/test/rustdoc/issue-85095.rs
Outdated
| @@ -0,0 +1,22 @@ | |||
| use std::ops::Deref; | |||
There was a problem hiding this comment.
Can you give this file a descriptive name instead of the issue number? "recursive-deref" or something is fine.
src/test/rustdoc/issue-85037.rs
Outdated
| @@ -0,0 +1,22 @@ | |||
| use std::ops::Deref; | |||
There was a problem hiding this comment.
Same thing here, can you use a descriptive name?
jyn514
added
the
T-rustdoc
|
@bors r+ |
|
📌 Commit 5f7d441 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=100 treeclosed=100 Closing the tree to run maintenance on the AArch64 CI runners. |
|
☀️ Test successful - checks-actions |
fix #85095
fix #85037