Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE when doc aliases were put on function params #86332

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Fix ICE when doc aliases were put on function params #86332

merged 1 commit into from
Jun 16, 2021
+13 −4

Conversation

rylev
Copy link
Member

@rylev rylev commented Jun 15, 2021

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2021
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass.

@michaelwoerister
Copy link
Member

@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Jun 16, 2021

📌 Commit 5f74ba5 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2021
@bors
Copy link
Contributor

bors commented Jun 16, 2021

⌛ Testing commit 5f74ba5 with merge 8daad74...

@bors
Copy link
Contributor

bors commented Jun 16, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 8daad74 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 16, 2021
@bors bors merged commit 8daad74 into rust-lang:master Jun 16, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 16, 2021
@rylev rylev deleted the fix-ice-docalias branch June 16, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
6 participants
@rylev @GuillaumeGomez @michaelwoerister @bors @rust-highfive @rustbot