Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust Float-Parsing Algorithms to use the Eisel-Lemire algorithm. #86761

Merged
merged 1 commit into from
Jul 17, 2021

Commits on Jul 17, 2021

  1. Changed dec2flt to use the Eisel-Lemire algorithm.

    Implementation is based off fast-float-rust, with a few notable changes.
    
    - Some unsafe methods have been removed.
    - Safe methods with inherently unsafe functionality have been removed.
    - All unsafe functionality is documented and provably safe.
    - Extensive documentation has been added for simpler maintenance.
    - Inline annotations on internal routines has been removed.
    - Fixed Python errors in src/etc/test-float-parse/runtests.py.
    - Updated test-float-parse to be a library, to avoid missing rand dependency.
    - Added regression tests for rust-lang#31109 and rust-lang#31407 in core tests.
    - Added regression tests for rust-lang#31109 and rust-lang#31407 in ui tests.
    - Use the existing slice primitive to simplify shared dec2flt methods
    - Remove Miri ignores from dec2flt, due to faster parsing times.
    
    - resolves rust-lang#85198
    - resolves rust-lang#85214
    - resolves rust-lang#85234
    - fixes rust-lang#31407
    - fixes rust-lang#31109
    - fixes rust-lang#53015
    - resolves rust-lang#68396
    - closes aldanor/fast-float-rust#15
    Alexhuszagh committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    8752b40 View commit details
    Browse the repository at this point in the history