Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cloning ExpnData to access Span edition #87106

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

Mark-Simulacrum
Copy link
Member

ExpnData is a fairly hefty structure to clone; cloning it may not be cheap. In
some cases this may get optimized out, but it's not clear that will always be
the case. Try to avoid that cost.

r? @ghost -- opening for a perf run to start with

ExpnData is a fairly hefty structure to clone; cloning it may not be cheap. In
some cases this may get optimized out, but it's not clear that will always be
the case. Try to avoid that cost.
@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 13, 2021
@bors
Copy link
Contributor

bors commented Jul 13, 2021

⌛ Trying commit 7d373c9 with merge df0c4b6e4afe07e7f2ce16b6218d1e8f6634de9c...

@bors
Copy link
Contributor

bors commented Jul 13, 2021

☀️ Try build successful - checks-actions
Build commit: df0c4b6e4afe07e7f2ce16b6218d1e8f6634de9c (df0c4b6e4afe07e7f2ce16b6218d1e8f6634de9c)

@rust-timer
Copy link
Collaborator

Queued df0c4b6e4afe07e7f2ce16b6218d1e8f6634de9c with parent 5aff6dd, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (df0c4b6e4afe07e7f2ce16b6218d1e8f6634de9c): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 13, 2021
@Mark-Simulacrum
Copy link
Member Author

It does seem like this is a consistent improvement on a number of benchmarks, even if a small one.

r? @petrochenkov perhaps (hopefully a quick approval)

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 13, 2021

📌 Commit 7d373c9 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2021
@bors
Copy link
Contributor

bors commented Jul 14, 2021

⌛ Testing commit 7d373c9 with merge 2155386...

@bors
Copy link
Contributor

bors commented Jul 14, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 2155386 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 14, 2021
@bors bors merged commit 2155386 into rust-lang:master Jul 14, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants