-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid cloning ExpnData to access Span edition #87106
Conversation
ExpnData is a fairly hefty structure to clone; cloning it may not be cheap. In some cases this may get optimized out, but it's not clear that will always be the case. Try to avoid that cost.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 7d373c9 with merge df0c4b6e4afe07e7f2ce16b6218d1e8f6634de9c... |
☀️ Try build successful - checks-actions |
Queued df0c4b6e4afe07e7f2ce16b6218d1e8f6634de9c with parent 5aff6dd, future comparison URL. |
Finished benchmarking try commit (df0c4b6e4afe07e7f2ce16b6218d1e8f6634de9c): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
It does seem like this is a consistent improvement on a number of benchmarks, even if a small one. r? @petrochenkov perhaps (hopefully a quick approval) |
@bors r+ |
📌 Commit 7d373c9 has been approved by |
☀️ Test successful - checks-actions |
ExpnData is a fairly hefty structure to clone; cloning it may not be cheap. In
some cases this may get optimized out, but it's not clear that will always be
the case. Try to avoid that cost.
r? @ghost -- opening for a perf run to start with