Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit Sized relaxation when attempting to relax other, unsupported trait #87250

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

robojumper
Copy link
Contributor

@robojumper robojumper commented Jul 18, 2021

Fixes #87199.

Do note that this bug fix causes code like the ref_arg::<[i32]>(&[5]); line in the test case in combination with an affected function to no longer compile.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2021
@petrochenkov
Copy link
Contributor

r? @nikomatsakis for review or reassignment

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2021

📌 Commit 3dbe0ce has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2021
@bors
Copy link
Contributor

bors commented Jul 22, 2021

⌛ Testing commit 3dbe0ce with merge 7db08ee...

@bors
Copy link
Contributor

bors commented Jul 22, 2021

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 7db08ee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 22, 2021
@bors bors merged commit 7db08ee into rust-lang:master Jul 22, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 22, 2021
@robojumper robojumper deleted the 87199-sized-relaxation branch July 22, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All relaxed bounds are assumed to be ?Sized
6 participants