Don't create references to uninitialized data in List::from_arena
#87268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 98e9d16 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2021
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#86230 (Add --nocapture option to rustdoc) - rust-lang#87210 (Rustdoc accessibility: make the sidebar headers actual headers) - rust-lang#87227 (Move asm! and global_asm! to core::arch) - rust-lang#87236 (Simplify command-line argument initialization on unix) - rust-lang#87251 (Fix "item info" width) - rust-lang#87256 (Extend HIR-based WF checking to associated type defaults) - rust-lang#87259 (triagebot shortcut config) - rust-lang#87268 (Don't create references to uninitialized data in `List::from_arena`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
resultandarena_slicewere references pointing to uninitialized data, which is technically UB. They may have been fine because the pointed data isCopyand and they were only written to, but the semantics of this aren't clearly defined yet, and since we have a sound way to do the same thing I don't think we should keep the possibly-unsound way.