Add long explanation for E0757 #87342
Conversation
|
Some changes occurred in diagnostic error codes |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| } | ||
| ``` | ||
|
|
||
| As `const` has a stricter set of requirements than `pure`, remove the `ffi_pure` |
There was a problem hiding this comment.
ffi_const you mean? Also, is there a documentation we could link to by any chance?
There was a problem hiding this comment.
Here I mean const. const and pure are C function attributes (e.g. see Common Function Attributes). Annotating a function with ffi_const says that it's C const, and annotating with ffi_pure says that it's C pure. I could use ffi_const and ffi_pure instead, but I felt it was more readable to lift the covers up to what they mean in GCC or other C compilers. What do you think?
I could link to ffi-pure and ffi-const from the unstable rust book. The former does mention that #[ffi_const] provides stronger guarantees, which implies that it's stricter.
There was a problem hiding this comment.
Please use ffi_* instead then. If I asked the questions, others will wonder about the same thing as well. Please add the links as well then.
|
Thanks! @bors: r+ rollup squash |
|
📌 Commit 8b75fec has been approved by |
bors
added
S-waiting-on-bors
…laumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#87187 (Fix NixOS detection) - rust-lang#87206 (avoid temporary vectors/reuse iterators) - rust-lang#87230 (Fix docblock <table> overflow) - rust-lang#87273 (Recognize bounds on impls as const bounds) - rust-lang#87279 (Add comments explaining the unix command-line argument support.) - rust-lang#87301 (Fix typo in compile.rs) - rust-lang#87311 (Get back the more precise suggestion spans of old regionck) - rust-lang#87321 (Add long explanation for E0722) - rust-lang#87342 (Add long explanation for E0757) Failed merges: - rust-lang#87270 (Don't display <table> in item summary) r? `@ghost` `@rustbot` modify labels: rollup
Helps with #61137