-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move calls to test_main into one function #87372
Conversation
@bors r+ rollup @GuillaumeGomez is there a reason you cc me on all these PRs? |
📌 Commit ef953b0 has been approved by |
On this one it's simply because I know you like to keep an eye on rustdoc "backend" changes. But I can stop if the notifications annoy you, as you prefer. :) |
ahh, that makes sense :) no worries, the pings are fine |
Thank you, this is definitely an improvement! It still seems surprising to me that there are two separate doctest-running functions ( |
@camelid they're different entry points: doctest is used by |
Hmm, Guillaume mentioned previously that |
Both of them are invoked from main rustdoc (rustdoc supports I don't think either could go away, but it does seem a little suspicious that this PR is not unifying the (seemingly overlooked?) support for unused externs in markdown tests. I at least would expect that to work just as well regardless of the input type... |
Just like @camelid said: one is run from rust code (we iterate through hir items and then check into their documentation if they have tests) whereas the second directly check from a markdown file (which is used by the error index as @jyn514 said). So we need to keep both, the goal here is to simply to merge the parts which can be merged. |
And yes, this is the part of the code which I referred to when I opened this issue. ;) |
…, r=jyn514 Move calls to test_main into one function Fixes rust-lang#86254. cc `@jyn514` r? `@camelid`
Rollup of 8 pull requests Successful merges: - rust-lang#87034 (DOC: fix hypothetical Rust code in `step_by()` docstring) - rust-lang#87298 (memorialize Anna Harren in the bastion of the turbofish) - rust-lang#87332 (Don't hide fields of enum struct variants) - rust-lang#87362 (Make `x.py d` an alias for `x.py doc`) - rust-lang#87372 (Move calls to test_main into one function) - rust-lang#87373 (Extend HIR WF checking to fields) - rust-lang#87376 (Change rustdoc logo to use the full container size) - rust-lang#87383 (Add regression tests for the impl_trait_in_bindings ICEs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #86254.
cc @jyn514
r? @camelid