Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEEE 754 is not an RFC #87419

Merged
merged 1 commit into from
Jul 24, 2021
Merged

IEEE 754 is not an RFC #87419

merged 1 commit into from
Jul 24, 2021

Conversation

programmerjake
Copy link
Member

If there were something between IEEE and 754, it would be STD: IEEE STD 754-2019

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2021
@inquisitivecrystal
Copy link
Contributor

inquisitivecrystal commented Jul 24, 2021

Random drive-by comment: to me, the version with STD seems a bit more readable, although I don't really know what the convention is here.

@programmerjake
Copy link
Member Author

I've always seen it written IEEE 754 or IEEE 754-2019 (or whatever date your favorite version was released on).

@nagisa
Copy link
Member

nagisa commented Jul 24, 2021

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Jul 24, 2021

📌 Commit 30b6197 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2021
@sthagen
Copy link

sthagen commented Jul 24, 2021

I've always seen it written IEEE 754 or IEEE 754-2019 (or whatever date your favorite version was released on).

In my experience you cite with the edition when you want to pin on that specific document and not intend to follow later editions when they come into effect in the future.

So I think keeping just IEEE 754 Is safe.

Note that one can always visit the normative pages for most standards and consider using there preferred citation. In this case:

"IEEE Standard for Floating-Point Arithmetic," in IEEE Std 754-2019 (Revision of IEEE 754-2008) , vol., no., pp.1-84, 22 July 2019, doi: 10.1109/IEEESTD.2019.8766229.

From https://ieeexplore.ieee.org/document/8766229

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 24, 2021
IEEE 754 is not an RFC

If there were something between `IEEE` and `754`, it would be `STD`: [`IEEE STD 754-2019`](https://doi.org/10.1109%2FIEEESTD.2019.8766229)
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2021
…arth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#87348 (Fix span when suggesting to add an associated type bound)
 - rust-lang#87359 (Remove detection of rustup and cargo in 'missing extern crate' diagnostics)
 - rust-lang#87370 (Add support for powerpc-unknown-freebsd)
 - rust-lang#87389 (Rename `known_attrs` to `expanded_inert_attrs` and move to rustc_expand)
 - rust-lang#87395 (Clear up std::env::set_var panic section.)
 - rust-lang#87403 (Implement `AssignToDroppingUnionField` in THIR unsafeck)
 - rust-lang#87410 (Mark `format_args_nl` as `#[doc(hidden)]`)
 - rust-lang#87419 (IEEE 754 is not an RFC)
 - rust-lang#87422 (DOC: remove unnecessary feature crate attribute from example code)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 25fab0c into rust-lang:master Jul 24, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants