Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust-specific emacs compilation regexp #8747

Closed
wants to merge 3 commits into from
Closed

Rust-specific emacs compilation regexp #8747

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
521fb04
compilation error regexp specific to rustc.
pnkfelix Aug 10, 2013
fe7092d
revisions to emacs compilation regexp, more readable and robust.
pnkfelix Aug 25, 2013
9d8897b
extend file regexp to match files with embedded spaces.
pnkfelix Aug 26, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/etc/emacs/rust-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,4 +225,27 @@ The initializer is `DEFAULT-TAB-WIDTH'.")

(provide 'rust-mode)

;; Issue #6887: Rather than inheriting the 'gnu compilation error
;; regexp (which is broken on a few edge cases), add our own 'rust
;; compilation error regexp and use it instead.
(defvar rustc-compilation-regexps
(let ((file "\\([^ \n]+\\)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if a filename does have a space in it?

(Note: I have no idea how this is supposed to work.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the regexp will not match.

I was about to claim that the 'gnu regexp makes the same trade-off, but I decided to actually check that claim. Which is good, because the claim would have been false.

(The docs for the gnu regexp claim that it matches file names composed of any non-newline char, apart from some particular exceptions, and direct experimentation seems to confirm this claim, though I cannot vouch for the regexp there since it is too big for me to decode. You can see that regexp with its documentation at mirrors/emacs.)

I'll see if I can improve upon this to support spaces as well.

(start-line "\\([0-9]+\\)")
(start-col "\\([0-9]+\\)")
(end-line "\\([0-9]+\\)")
(end-col "\\([0-9]+\\)")
(error-or-warning "\\(?:[Ee]rror\\|\\([Ww]arning\\)\\)"))
(let ((re (concat "^" file ":" start-line ":" start-col
": " end-line ":" end-col
" \\(?:[Ee]rror\\|\\([Ww]arning\\)\\):")))
(cons re '(1 (2 . 4) (3 . 5) (6)))))
"Specifications for matching errors in rustc invocations.
See `compilation-error-regexp-alist for help on their format.")

(eval-after-load 'compile
'(progn
(add-to-list 'compilation-error-regexp-alist-alist
(cons 'rustc rustc-compilation-regexps))
(add-to-list 'compilation-error-regexp-alist 'rustc)))

;;; rust-mode.el ends here