Point to where clause for GATs to add bound #87478
Conversation
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #87948) made this pull request unmergeable. Please resolve the merge conflicts. |
| if !generics.where_clause.predicates.is_empty() { "," } else { " where" }, | ||
| pred, | ||
| ); | ||
| err.span_suggestion( |
There was a problem hiding this comment.
Let's make the suggestion a bit easier to read, given that it points at a span right in the middle of a larger span:
| err.span_suggestion( | |
| err.span_suggestion_verbose( |
There was a problem hiding this comment.
Although that would require rewording the other span label...
There was a problem hiding this comment.
I leave it to your decision what to do here.
There was a problem hiding this comment.
So, now that the associated type points to the type itself, not the whole defintion, they don't overlap anymore.
I do think the verbose suggestion would be nice, but I'll leave that as a followup.
| @@ -0,0 +1,40 @@ | |||
| #![feature(generic_associated_types)] | |||
There was a problem hiding this comment.
Can we mark the tests // run-rustfix?
There was a problem hiding this comment.
So...no. The suggestion here doesn't actually result in code that compiles, because it causes the where clauses not to match the trait's where clauses. (In fact, in this case, we can't write this where clause in the trait, we would have to use Self)
Unfortunately, that's a whole separate issue with GATs. But applying the current suggestion should help, in the future, to guide the user towards matching the trait's where clauses.
|
r=me after cleaning up the commented out code. |
|
@bors r=estebank |
|
📌 Commit 22fc7d6 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Fixes #84931
r? @estebank