Add missing examples for NonNull #87547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
A-docs
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
nonnull-examples
branch
from
6cf5fc8
to
8f7dba8
Compare
kennytm
reviewed
Jul 30, 2021
GuillaumeGomez
force-pushed
the
nonnull-examples
branch
from
8f7dba8
to
4ace7e7
Compare
|
Updated! |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
nonnull-examples
branch
from
4ace7e7
to
cfe9858
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
nonnull-examples
branch
from
cfe9858
to
1bbe618
Compare
|
@bors: r=kennytm rollup |
|
📌 Commit 1bbe618 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 30, 2021
…kennytm Add missing examples for NonNull
This was referenced Jul 30, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#86072 (Cross compiling rustc_llvm on Darwin requires zlib.) - rust-lang#87385 (Make `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` warn by default) - rust-lang#87547 (Add missing examples for NonNull) - rust-lang#87557 (Fix issue with autofix for ambiguous associated function from Rust 2021 prelude when struct is generic) - rust-lang#87559 (Tweak borrowing suggestion in `for` loop) - rust-lang#87596 (Add warning when whitespace is not skipped after an escaped newline) - rust-lang#87606 (Add some TAIT-related regression tests) - rust-lang#87609 (Add docs about performance and `Iterator::map` to `[T; N]::map`) - rust-lang#87616 (Fix missing word in rustdoc book) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
RalfJung
reviewed
Jul 31, 2021
| /// let ptr = unsafe { NonNull::new_unchecked(&mut x as *mut _) }; | ||
| /// | ||
| /// // NEVER DO THAT!!! | ||
| /// let ptr = unsafe { NonNull::<u32>::new_unchecked(std::ptr::null_mut()) }; |
There was a problem hiding this comment.
Please mark testcases that cause UB as no_run (see e.g. the MaybeUninit docs).
Otherwise, https://github.com/rust-lang/miri-test-libstd/ will fail.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 2, 2021
mark a UB doctest as no_run See rust-lang#87547 (comment) Cc `@GuillaumeGomez` `@kennytm`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.