Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back -Zno-profiler-runtime #87756

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Aug 4, 2021

This was removed by #85284 in favor of -Zprofiler-runtime=<name>.However the suggested -Zprofiler-runtime=None doesn't work becauseNone is treated as a crate name.

This was removed by rust-lang#85284 in favor of -Zprofiler-runtime=<name>.
However the suggested -Zprofiler-runtime=None doesn't work because
"None" is treated as a crate name.
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2021
@jackh726
Copy link
Member

jackh726 commented Aug 4, 2021

Wait how do the other optional flags work then? Can they ever be None then?

@Amanieu
Copy link
Member Author

Amanieu commented Aug 4, 2021

All the other optional flags default to None and are changed to Some when you specify them on the command-line.

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to change the parsing for optional args to count "None" as None. It'd be nice to not have two flags here.

But I think this is fine for now.

@jackh726
Copy link
Member

jackh726 commented Aug 4, 2021

r? @jackh726

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 4, 2021

📌 Commit 1247f9b has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 6, 2021
…h726

Add back -Zno-profiler-runtime

This was removed by rust-lang#85284 in favor of `-Zprofiler-runtime=<name>`.However the suggested `-Zprofiler-runtime=None` doesn't work because`None` is treated as a crate name.
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2021
Rollup of 9 pull requests

Successful merges:

 - rust-lang#87561 (thread set_name haiku implementation.)
 - rust-lang#87715 (Add long error explanation for E0625)
 - rust-lang#87727 (explicit_generic_args_with_impl_trait: fix min expected number of generics)
 - rust-lang#87742 (Validate FFI-safety warnings on naked functions)
 - rust-lang#87756 (Add back -Zno-profiler-runtime)
 - rust-lang#87759 (Re-use std::sealed::Sealed in os/linux/process.)
 - rust-lang#87760 (Promote `aarch64-apple-ios-sim` to Tier 2)
 - rust-lang#87770 (permit drop impls with generic constants in where clauses)
 - rust-lang#87780 (alloc: Use intra doc links for the reserve function)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5a36cdb into rust-lang:master Aug 6, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants