Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to edition guide instead of issues for 2021 lints. #87885

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Aug 9, 2021

This changes the 2021 lints to not link to github issues, but to the edition guide instead.

Fixes #86996

@m-ou-se m-ou-se added D-edition Diagnostics: An error or lint that should account for edition differences. A-edition-2021 Area: The 2021 edition labels Aug 9, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2021
@m-ou-se
Copy link
Member Author

m-ou-se commented Aug 9, 2021

@bors delegate=rylev

(Feel free to delegate to someone else if you prefer.)

@bors
Copy link
Contributor

bors commented Aug 9, 2021

✌️ @rylev can now approve this pull request

@rylev
Copy link
Member

rylev commented Aug 11, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 11, 2021

📌 Commit 260f9b9 has been approved by rylev

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 11, 2021
Link to edition guide instead of issues for 2021 lints.

This changes the 2021 lints to not link to github issues, but to the edition guide instead.

Fixes  rust-lang#86996
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 11, 2021
Link to edition guide instead of issues for 2021 lints.

This changes the 2021 lints to not link to github issues, but to the edition guide instead.

Fixes  rust-lang#86996
@JohnTitor
Copy link
Member

Failed in rollup: #87943 (comment)
Some Clippy UI tests also need to update.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2021
@m-ou-se
Copy link
Member Author

m-ou-se commented Aug 12, 2021

@bors r=rylev

@bors
Copy link
Contributor

bors commented Aug 12, 2021

📌 Commit a851b56 has been approved by rylev

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2021
…laumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#87819 (Use a more accurate span on assoc types WF checks)
 - rust-lang#87863 (Fix Windows Command::env("PATH"))
 - rust-lang#87885 (Link to edition guide instead of issues for 2021 lints.)
 - rust-lang#87941 (Fix/improve rustdoc-js tool)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3d733f6 into rust-lang:master Aug 12, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 12, 2021
@m-ou-se m-ou-se deleted the edition-guide-links branch August 12, 2021 16:29
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 3, 2021
Link to edition guide instead of issues for 2021 lints.

This changes the 2021 lints to not link to github issues, but to the edition guide instead.

Fixes  rust-lang#86996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2021 Area: The 2021 edition D-edition Diagnostics: An error or lint that should account for edition differences. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to edition guide from lints.
6 participants