Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatly improve limitation handling on parallel rustdoc GUI test run #88188

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #88082.

r? @dns2utf8

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 20, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the rustdoc-gui-parallel-limit branch from ae9dc54 to 839ea2d Compare August 21, 2021 16:07
@GuillaumeGomez
Copy link
Member Author

@the8472 I implemented your suggestion, thanks a lot! I discovered Promise.race. :)

Copy link
Contributor

@dns2utf8 dns2utf8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I have some minor change requests

src/tools/rustdoc-gui/tester.js Outdated Show resolved Hide resolved
src/tools/rustdoc-gui/tester.js Outdated Show resolved Hide resolved
src/tools/rustdoc-gui/tester.js Show resolved Hide resolved
src/tools/rustdoc-gui/tester.js Show resolved Hide resolved
src/tools/rustdoc-gui/tester.js Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the rustdoc-gui-parallel-limit branch from 839ea2d to b7fe005 Compare August 23, 2021 12:26
@GuillaumeGomez
Copy link
Member Author

@bors: r=dns2utf8 rollup

@bors
Copy link
Contributor

bors commented Aug 23, 2021

📌 Commit b7fe005 has been approved by dns2utf8

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 23, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2021
Rollup of 6 pull requests

Successful merges:

 - rust-lang#87976 (Account for tabs when highlighting multiline code suggestions)
 - rust-lang#88174 (Clarify some wording in Rust 2021 lint docs)
 - rust-lang#88188 (Greatly improve limitation handling on parallel rustdoc GUI test run)
 - rust-lang#88230 (Fix typos “a”→“an”)
 - rust-lang#88232 (Add notes to macro-not-found diagnostics to point out how things with the same name were not a match.)
 - rust-lang#88259 (Do not mark `-Z thir-unsafeck` as unsound anymore)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6d1c5b6 into rust-lang:master Aug 23, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 23, 2021
@GuillaumeGomez GuillaumeGomez deleted the rustdoc-gui-parallel-limit branch August 24, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants