Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve type variables after checking casts #88266

Merged
merged 6 commits into from
Aug 24, 2021
Merged

resolve type variables after checking casts #88266

merged 6 commits into from
Aug 24, 2021

Conversation

nikomatsakis
Copy link
Contributor

r? @jackh726

Fixes #87814
Fixes #88118

Supercedes #87879 (cc @ldm0)

ldm0 and others added 3 commits August 23, 2021 19:16
@ldm0 @nikomatsakis
select obligations after check_casts
e891044 
Otherwise, we can get into a situation where you have
a subtype obligation `#1 <: #2` pending, #1 is constrained
by `check_casts`, but #2` is unaffected.

Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
@nikomatsakis
fix apparent typo in resolving variables
af15e52
@nikomatsakis
useful debug printouts
754d51e 
The changes to dumping expressions seem particularly useful
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2021
@nikomatsakis nikomatsakis mentioned this pull request Aug 23, 2021
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jackh726
Copy link
Member

r=me with CI passing

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2021

📌 Commit ec9531b has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2021
@nikomatsakis
Copy link
Contributor Author

@bors p=1

Rust 2021 Blocker.

@bors
Copy link
Contributor

bors commented Aug 24, 2021

⌛ Testing commit ec9531b with merge b03ccac...

@bors
Copy link
Contributor

bors commented Aug 24, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing b03ccac to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 24, 2021
@bors bors merged commit b03ccac into rust-lang:master Aug 24, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 24, 2021
@narpfel narpfel mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

PlaceBuilder ICE, Part 2 Closure captures immutable reference when mutable reference is necessary
7 participants
@nikomatsakis @rust-log-analyzer @jackh726 @bors @rust-highfive @rustbot @ldm0