Fix debuginfo for parameters passed via the ScalarPair abi on Windows #88629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleywiser
added
A-debuginfo
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
approved these changes
Sep 4, 2021
There was a problem hiding this comment.
When adding instrumentation to a function I usually also go through the function and update all debug! invocations to their tracing equivalent
- debug!("hello: foo = {:?}", foo);
+ debug!(?foo, "hello");Not saying you have to do this, that's just what I've been doing ^^.
|
@bors r+ |
|
📌 Commit 7bbdc884a2258f96fcff8fcea3d4d6e2acf6e294 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7bbdc884a2258f96fcff8fcea3d4d6e2acf6e294 with merge f60df93e93ea66543bb55346f0f264a9bb70da07... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
wesleywiser
force-pushed
the
fix_debuginfo_for_scalarpair_params
branch
from
7bbdc88
to
3195401
Compare
|
📌 Commit 3195401 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 12, 2021
…rpair_params, r=oli-obk Fix debuginfo for parameters passed via the ScalarPair abi on Windows Mark all of these as locals so the debugger does not try to interpret them as being a pointer to the value. This extends the approach used in rust-lang#81898. Fixes rust-lang#88625
|
@bors r- |
bors
added
S-waiting-on-author
Mark all of these as locals so the debugger does not try to interpret them as being a pointer to the value. This extends the approach used in PR rust-lang#81898.
wesleywiser
force-pushed
the
fix_debuginfo_for_scalarpair_params
branch
from
3195401
to
a6c642a
Compare
|
Resolved type name for @bors r=oli-obk |
|
📌 Commit a6c642a has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a6c642a with merge 384ced8504e71333555a67050fff22e7eddd2df7... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (5fd6f3b): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark all of these as locals so the debugger does not try to interpret
them as being a pointer to the value. This extends the approach used
in #81898.
Fixes #88625