Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove optimization_fuel_crate from Session" #88748

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Revert "Remove optimization_fuel_crate from Session" #88748

merged 1 commit into from
Sep 9, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Sep 8, 2021

This reverts commit 5464b2e.

This hopefully fixes the perf regression in #88530 (comment).

@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2021
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 8, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 8, 2021
@bors
Copy link
Contributor

bors commented Sep 8, 2021

⌛ Trying commit 1022646 with merge 74f6fa827dfc2894e627fea79cf03f0927c74911...

@bjorn3 bjorn3 mentioned this pull request Sep 8, 2021
Merged
wesleywiser
wesleywiser approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if the perf looks good

@bors
Copy link
Contributor

bors commented Sep 8, 2021

☀️ Try build successful - checks-actions
Build commit: 74f6fa827dfc2894e627fea79cf03f0927c74911 (74f6fa827dfc2894e627fea79cf03f0927c74911)

@rust-timer
Copy link
Collaborator

Queued 74f6fa827dfc2894e627fea79cf03f0927c74911 with parent 434cb43, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (74f6fa827dfc2894e627fea79cf03f0927c74911): comparison url.

Summary: This change led to large relevant improvements 🎉 in compiler performance.

  • Large improvement in instruction counts (up to -2.7% on full builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 8, 2021
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 8, 2021

This fixes the worst of the perf regression, but not completely.

@bors r=wesleywiser

@bors
Copy link
Contributor

bors commented Sep 8, 2021

📌 Commit 1022646 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2021
@bors
Copy link
Contributor

bors commented Sep 9, 2021

⌛ Testing commit 1022646 with merge 02a57fa...

@bors
Copy link
Contributor

bors commented Sep 9, 2021

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 02a57fa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2021
@bors bors merged commit 02a57fa into rust-lang:master Sep 9, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 9, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (02a57fa): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@bjorn3 bjorn3 deleted the try_fix_perf_regression branch September 9, 2021 14:49
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 9, 2021

Why didn't this result in a perf improvement after all?

@tmiasko tmiasko mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bjorn3 @rust-highfive @rust-timer @bors @wesleywiser @rustbot