Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump stage0 compiler to 1.56 #88752

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Bump stage0 compiler to 1.56 #88752

merged 1 commit into from
Sep 9, 2021

Conversation

Mark-Simulacrum
Copy link
Member

r? @pietroalbini (but others should feel free to steal)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Sep 8, 2021

Yess, time to bump the compiler and library to edition = "2021"!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 8, 2021

📌 Commit 1bbb74cf695e9b0f8b80374b83e98ec66ed001d9 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2021
@Mark-Simulacrum
Copy link
Member Author

@bors r=m-ou-se

@bors
Copy link
Contributor

bors commented Sep 8, 2021

📌 Commit b6976a213e43f100f1b50a306b6773be2c66afc5 has been approved by m-ou-se

@pietroalbini
Copy link
Member

Also looks good to me!

@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 9, 2021
@Mark-Simulacrum
Copy link
Member Author

@bors r=m-ou-se p=1

@bors
Copy link
Contributor

bors commented Sep 9, 2021

📌 Commit 3ad6e84faa5c6abbe88131384a8a64ee37f18218 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member Author

@bors r=m-ou-se p=1

@bors
Copy link
Contributor

bors commented Sep 9, 2021

📌 Commit b4e7649 has been approved by m-ou-se

@bors
Copy link
Contributor

bors commented Sep 9, 2021

⌛ Testing commit b4e7649 with merge c5cbf78...

@bors
Copy link
Contributor

bors commented Sep 9, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing c5cbf78 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2021
@bors bors merged commit c5cbf78 into rust-lang:master Sep 9, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 9, 2021
@bors bors mentioned this pull request Sep 9, 2021
Merged
@bors bors mentioned this pull request Sep 9, 2021
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c5cbf78): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

  • Very small improvement in instruction counts (up to -0.8% on incr-patched: println builds of regression-31157)
  • Moderate regression in instruction counts (up to 0.9% on incr-unchanged builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Sep 9, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the bootstrap-bump branch September 9, 2021 13:13
@Mark-Simulacrum
Copy link
Member Author

The regressions are pretty small, and scattered in +/- about equally. This PR also at least in theory doesn't change the compiler or standard library being benchmarked, so the differences are likely due to "noise" (presumably related to changes to the memory layout or something similar).

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@pietroalbini pietroalbini

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Mark-Simulacrum @m-ou-se @bors @pietroalbini @rust-log-analyzer @rust-timer @rust-highfive @rustbot