Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some tests to more reasonable directories - 7 #88883

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Move some tests to more reasonable directories - 7 #88883

merged 1 commit into from
Sep 17, 2021

Conversation

c410-f3r
Copy link
Contributor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2021
@petrochenkov
Copy link
Contributor

issue-5791.rs -> can be removed, already tested in clashing-extern-fn.rs
expr-empty-ret.rs -> never_type
guards.rs -> match
issue-33498.rs -> match
enable-unstable-lib-feature.rs -> stability-attribute
backtrace-debuginfo.rs -> certainly not macros, not sure about the proper subdirectory, let's keep it in its old place
issue-41255.rs -> lint or match
issue-79744.rs -> lint
out-of-order-shadowing.rs -> macros
issue-78720.rs -> closures
use-self-in-inner-fn.rs -> resolve

(binding and use are confirmed to be garbage subdirectories)

Could you also update the test number limits in tidy?

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@c410-f3r
Copy link
Contributor Author

Done

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@c410-f3r
Copy link
Contributor Author

enable-unstable-lib-feature, lint-stability and list-stability-deprecated are all placed inside lint because of shared aux-build:stability-cfg2.rs.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 15, 2021

📌 Commit 1b0186e has been approved by petrochenkov

@bors
Copy link
Contributor

bors commented Sep 15, 2021

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 15, 2021
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 16, 2021
@Manishearth
Rollup merge of rust-lang#88883 - c410-f3r:tests, r=petrochenkov
63cfeba 
Move some tests to more reasonable directories - 7

cc rust-lang#73494
r? `@petrochenkov`
@Manishearth Manishearth mentioned this pull request Sep 16, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request Sep 17, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2021
@bors
Auto merge of rust-lang#89037 - JohnTitor:rollup-rd9btbs, r=JohnTitor
1c03f0d 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#86382 (Make diagnostics clearer for `?` operators)
 - rust-lang#87529 (Fix ICE in `improper_ctypes_definitions` lint with all-ZST transparent types)
 - rust-lang#88339 (Add TcpListener::into_incoming and IntoIncoming)
 - rust-lang#88735 (Don't lint about missing code examples in derived traits)
 - rust-lang#88751 (Couple of changes to FileSearch and SearchPath)
 - rust-lang#88883 (Move some tests to more reasonable directories - 7)
 - rust-lang#88887 (Const Deref)
 - rust-lang#88911 (Improve error message for type mismatch in generator arguments)
 - rust-lang#89014 (PassWrapper: handle separate Module*SanitizerPass)
 - rust-lang#89033 (Set the library path in sysroot-crates-are-unstable)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5e91037 into rust-lang:master Sep 17, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
6 participants
@c410-f3r @petrochenkov @rust-log-analyzer @bors @rust-highfive @rustbot