Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit log level in tracing instrument macro #88980

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Sep 15, 2021

Specify a log level in tracing instrument macro explicitly.

Additionally reduce the used log level from a default info level to a
debug level (all of those appear to be developer oriented logs, so there
should be no need to include them in release builds).

Specify a log level in tracing instrument macro explicitly.

Additionally reduce the used log level from a default info level to a
debug level (all of those appear to be developer oriented logs, so there
should be no need to include them in release builds).
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Sep 15, 2021

@cjgillot, @oli-obk let me know if you would like to retain the existing info log level for some of those.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 15, 2021

@bors try @rust-timer queue

No, this is great. I wanted to figure out a way to set the default to debug, but until then, all of them should have an explicit level

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 15, 2021
@bors
Copy link
Contributor

bors commented Sep 15, 2021

⌛ Trying commit b6b19f3 with merge 5f9ebbce9a7892f65005d6e86e1c855efa283318...

@bors
Copy link
Contributor

bors commented Sep 15, 2021

☀️ Try build successful - checks-actions
Build commit: 5f9ebbce9a7892f65005d6e86e1c855efa283318 (5f9ebbce9a7892f65005d6e86e1c855efa283318)

@rust-timer
Copy link
Collaborator

Queued 5f9ebbce9a7892f65005d6e86e1c855efa283318 with parent 2c7bc5e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5f9ebbce9a7892f65005d6e86e1c855efa283318): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 15, 2021
@jyn514
Copy link
Member

jyn514 commented Sep 16, 2021

@hawkw do you happen to know if there's a way to change the default log level for #[instrument]?

@oli-obk
Copy link
Contributor

oli-obk commented Sep 16, 2021

@bors r+

hawkw do you happen to know if there's a way to change the default log level for #[instrument]?

this is tracked in tokio-rs/tracing#1070 (removing default log levels entirely and always requiring them)

@bors
Copy link
Contributor

bors commented Sep 16, 2021

📌 Commit b6b19f3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2021
@bors
Copy link
Contributor

bors commented Sep 18, 2021

⌛ Testing commit b6b19f3 with merge 5438ee4...

@bors
Copy link
Contributor

bors commented Sep 18, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 5438ee4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2021
@bors bors merged commit 5438ee4 into rust-lang:master Sep 18, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 18, 2021
@tmiasko tmiasko deleted the instrument-debug branch September 18, 2021 09:35
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5438ee4): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants