-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use explicit log level in tracing instrument macro #88980
Conversation
Specify a log level in tracing instrument macro explicitly. Additionally reduce the used log level from a default info level to a debug level (all of those appear to be developer oriented logs, so there should be no need to include them in release builds).
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue No, this is great. I wanted to figure out a way to set the default to debug, but until then, all of them should have an explicit level |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit b6b19f3 with merge 5f9ebbce9a7892f65005d6e86e1c855efa283318... |
☀️ Try build successful - checks-actions |
Queued 5f9ebbce9a7892f65005d6e86e1c855efa283318 with parent 2c7bc5e, future comparison URL. |
Finished benchmarking commit (5f9ebbce9a7892f65005d6e86e1c855efa283318): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@hawkw do you happen to know if there's a way to change the default log level for |
@bors r+
this is tracked in tokio-rs/tracing#1070 (removing default log levels entirely and always requiring them) |
📌 Commit b6b19f3 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (5438ee4): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Specify a log level in tracing instrument macro explicitly.
Additionally reduce the used log level from a default info level to a
debug level (all of those appear to be developer oriented logs, so there
should be no need to include them in release builds).