Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented MIN and MAX constants for the non-zero integer types. #89076

Closed
wants to merge 5 commits into from

Conversation

mjclements
Copy link

Per Issue #89065, I added the constants to the non-zero integer types.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling unwind v0.0.0 (/checkout/library/unwind)
error: expected expression, found `$`
   --> library/core/src/num/nonzero.rs:914:67
    |
899 | / macro_rules! nonzero_min_max {
900 | |     ( $( $MinVal:expr , $Ty: ident($Int: ty); )+ ) => {
901 | |         $(
902 | |             impl $Ty {
...   |
914 | |                 pub const MIN : $Ty = unsafe { $Ty::new_unchecked($Min)};
...   |
917 | |     }
918 | | }
918 | | }
    | |_- in this expansion of `nonzero_min_max!`
919 | 
920 | / nonzero_min_max! {
921 | |     1 , NonZeroU8(u8);
922 | |     1 , NonZeroU16(u16);
923 | |     1 , NonZeroU32(u32);
...   |
932 | |     isize::MIN  , NonZeroIsize(isize);
    | |_- in this macro invocation

error: could not compile `core` due to previous error
Build completed unsuccessfully in 0:01:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants