-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for issue #83564 #89283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
A-testsuite
Area: The testsuite used to check the correctness of rustc
labels
Sep 26, 2021
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Sep 26, 2021
camelid
commented
Sep 26, 2021
src/test/ui/suggestions/core-std-import-order-issue-83564.stderr
Outdated
Show resolved
Hide resolved
camelid
force-pushed
the
issue-83564-test
branch
from
September 26, 2021 19:39
477c598
to
df687bd
Compare
Diff from nightly to master: diff --git a/old.txt b/new.txt
index e22f6b1433f..b9fd6b98937 100644
--- a/old.txt
+++ b/new.txt
@@ -6,10 +6,10 @@ error[E0433]: failed to resolve: use of undeclared type `NonZeroU32`
|
help: consider importing one of these items
|
-6 | use core::num::NonZeroU32;
- |
6 | use std::num::NonZeroU32;
|
+6 | use core::num::NonZeroU32;
+ |
error: aborting due to previous error |
davidtwco
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@bors r+ rollup |
📌 Commit df687bd has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 27, 2021
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 28, 2021
Add regression test for issue rust-lang#83564 cc rust-lang#83564 r? `@davidtwco`
This was referenced Sep 28, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 29, 2021
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#87260 (Libgccjit codegen) - rust-lang#89212 (x.py: run `rustup toolchain link` in setup) - rust-lang#89233 (Hide `<...> defined here` note if the source is not available) - rust-lang#89235 (make junit output more consistent with default format) - rust-lang#89255 (Fix incorrect disambiguation suggestion for associated items) - rust-lang#89276 (Fix the population of the `union.impls` field) - rust-lang#89283 (Add regression test for issue rust-lang#83564) - rust-lang#89318 (rustc_session: Remove lint store from `Session`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #83564
r? @davidtwco