refactor: VecDeques Iter fields to private #89685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
the8472
added
the
T-libs
jyn514
reviewed
Nov 9, 2021
jyn514
added
the
C-cleanup
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
|
@joshtriplett this is ready for review |
|
Rebased 👍 |
|
☔ The latest upstream changes (presumably #94472) made this pull request unmergeable. Please resolve the merge conflicts. |
Made the fields of VecDeque's Iter private by creating a Iter::new(...) function to create a new instance of Iter and migrating usage to use Iter::new(...).
|
Rebased and resolved conflict. |
JohnCSimon
added
S-waiting-on-review
|
📌 Commit cf30ac8 has been approved by |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 30, 2022
…e, r=oli-obk refactor: VecDeques Iter fields to private Made the fields of VecDeque's Iter private by creating a Iter::new(...) function to create a new instance of Iter and migrating usage to use Iter::new(...).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 31, 2022
…piler-errors Rollup of 6 pull requests Successful merges: - rust-lang#89685 (refactor: VecDeques Iter fields to private) - rust-lang#97172 (Optimize the diagnostic generation for `extern unsafe`) - rust-lang#97395 (Miri call ABI check: ensure type size+align stay the same) - rust-lang#97431 (don't do `Sized` and other return type checks on RPIT's real type) - rust-lang#97555 (Source code page: line number click adds `NaN`) - rust-lang#97558 (Fix typos in comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the fields of VecDeque's Iter private by creating a Iter::new(...) function to create a new instance of Iter and migrating usage to use Iter::new(...).