-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move top part of print_item to Tera templates #89695
Conversation
Add print_item.html and the code in print_item.rs to use it.
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Thanks for the PR and the answers! r=me once CI pass |
@bors r=GuillaumeGomez rollup |
📌 Commit d0a33fb has been approved by |
Since it can impact performance, let's not put it into the rollup. @bors: rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c1cb974): comparison url. Summary: This change led to large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
@jsha: It's a big regression for doc build time... Time for optimization I guess. :) |
Part of #84419.
This moves the first line of each item page (E.g.
Struct foo::Bar .... 1.0.0 [-][src]
into a Tera template.I also moved template initialization into its own module and added a small macro to reduce duplication and opportunity for errors.