Add long explanation for error E0482 #89710
Conversation
|
Some changes occurred in diagnostic error codes |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
| } | ||
| ``` | ||
|
|
||
| [`impl Trait`] feature in return type have implicit `'static` lifetime |
There was a problem hiding this comment.
| [`impl Trait`] feature in return type have implicit `'static` lifetime | |
| The [`impl Trait`] feature uses an implicit `'static` lifetime restriction in the returned type |
There was a problem hiding this comment.
I fixed that part and split the sentence in two. I also made it sound different, because before the explanation sounded like all -> impl Trait structures force 'static lifetime in all cases (like Box<Trait>), which is not true according to RFC I believe.
Those can be different lifetimes and only my example required 'static. Please correct me if I'm wrong @GuillaumeGomez or @nagisa.
| @@ -11,7 +11,7 @@ use regex::Regex; | |||
| // A few of those error codes can't be tested but all the others can and *should* be tested! | |||
| const EXEMPTED_FROM_TEST: &[&str] = &[ | |||
| "E0227", "E0279", "E0280", "E0313", "E0377", "E0461", "E0462", "E0464", "E0465", "E0476", | |||
| "E0482", "E0514", "E0519", "E0523", "E0554", "E0640", "E0717", "E0729", | |||
| "E0514", "E0519", "E0523", "E0554", "E0640", "E0717", "E0729", | |||
|
Once these are done, I think it'll be good to be merged. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 0fde6f6 has been approved by |
bors
added
S-waiting-on-bors
|
Thanks for the review @GuillaumeGomez! |
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#89471 (Use Ancestory to check default fn in const impl instead of comparing idents) - rust-lang#89643 (Fix inherent impl overlap check.) - rust-lang#89651 (Add `Poll::ready` and revert stabilization of `task::ready!`) - rust-lang#89675 (Re-use TypeChecker instead of passing around some of its fields ) - rust-lang#89710 (Add long explanation for error E0482) - rust-lang#89756 (Greatly reduce amount of debuginfo compiled for bootstrap itself) - rust-lang#89760 (Remove hack ignoring unused attributes for stage 0 std) - rust-lang#89772 (Fix function-names test for GDB 10.1) - rust-lang#89785 (Fix ICE when compiling nightly std/rustc on beta compiler) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This is longer explanation for error E0482 in the #61137.
Please take a look and leave some feedback!