-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature flag for type_changing_struct_update
#89730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crlf0710
added
the
F-type-changing-struct-update
`#![feature(type_changing_struct_update)]`
label
Oct 10, 2021
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 10, 2021
crlf0710
force-pushed
the
type_changing_feature
branch
2 times, most recently
from
October 10, 2021 06:59
6c49959
to
6721482
Compare
This comment has been minimized.
This comment has been minimized.
crlf0710
force-pushed
the
type_changing_feature
branch
from
October 10, 2021 08:36
6721482
to
64caf12
Compare
This comment has been minimized.
This comment has been minimized.
crlf0710
force-pushed
the
type_changing_feature
branch
2 times, most recently
from
October 11, 2021 06:21
3bc6ad7
to
a14e3fb
Compare
apiraino
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Oct 14, 2021
crlf0710
added
the
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
label
Oct 14, 2021
jackh726
reviewed
Oct 21, 2021
r=me with tracking issue changed |
jackh726
force-pushed
the
type_changing_feature
branch
from
October 22, 2021 15:55
3b0727c
to
7d7ebf8
Compare
I've updated the tracking issue and version, but otherwise done nothing. @bors r+ rollup |
📌 Commit 7d7ebf8 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 22, 2021
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 22, 2021
…ackh726 add feature flag for `type_changing_struct_update` This implements the PR0 part of the mentoring notes within rust-lang#86618. overrides the previous inactive rust-lang#86646 pr. r? `@nikomatsakis`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 22, 2021
…ackh726 add feature flag for `type_changing_struct_update` This implements the PR0 part of the mentoring notes within rust-lang#86618. overrides the previous inactive rust-lang#86646 pr. r? ``@nikomatsakis``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 23, 2021
…askrgr Rollup of 11 pull requests Successful merges: - rust-lang#83233 (Implement split_array and split_array_mut) - rust-lang#88300 (Stabilise unix_process_wait_more, extra ExitStatusExt methods) - rust-lang#89416 (nice_region_error: Include lifetime placeholders in error output) - rust-lang#89468 (Report fatal lexer errors in `--cfg` command line arguments) - rust-lang#89730 (add feature flag for `type_changing_struct_update`) - rust-lang#89920 (Implement -Z location-detail flag) - rust-lang#90070 (Add edition configuration to compiletest) - rust-lang#90087 (Sync rustfmt subtree) - rust-lang#90117 (Make RSplit<T, P>: Clone not require T: Clone) - rust-lang#90122 (CI: make docker cache download and `docker load` time out after 10 minutes) - rust-lang#90166 (Add comment documenting why we can't use a simpler solution) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
F-type-changing-struct-update
`#![feature(type_changing_struct_update)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the PR0 part of the mentoring notes within #86618.
overrides the previous inactive #86646 pr.
r? @nikomatsakis