-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some more testcases #89768
add some more testcases #89768
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'll try that again tomorrow, when the new nightly is built. On the current nightly (rustc 1.57.0-nightly (41dfaaa 2021-10-10)) it does not ICE. Maybe something happened in the last 17 hours. |
I think |
"resolves" seems to work for github (see "linked issues" on right)
If this is indeed the case, please ping me/file a followup issue; let's nip this in the bud. |
This comment has been minimized.
This comment has been minimized.
The keywords were highlighted before, but they aren't in my current post. That's why I was/am confused. The testcase of issue 88586 doesn't ICE for me locally, even with nightly-2021-10-11:
I'll remove that testcase and open a new issue. |
Without that testcase it works, CI is done... weird. |
@bors r+ rollup |
📌 Commit 0767ed3 has been approved by |
add some more testcases resolves rust-lang#52893 resolves rust-lang#68295 resolves rust-lang#87750 resolves rust-lang#88071 All these issues have been fixed according to glacier. Just adding a test so it can be closed. Can anybody tell me why the github keywords do not work? 🤔 Please edit this post if you can fix it.
add some more testcases resolves rust-lang#52893 resolves rust-lang#68295 resolves rust-lang#87750 resolves rust-lang#88071 All these issues have been fixed according to glacier. Just adding a test so it can be closed. Can anybody tell me why the github keywords do not work? 🤔 Please edit this post if you can fix it.
Rollup of 12 pull requests Successful merges: - rust-lang#89768 (add some more testcases) - rust-lang#89777 (Edit explanation of test for nested type ascriptions) - rust-lang#89781 (Add missing words in `Infallible` docs) - rust-lang#89782 (Improve CJK font in rustdoc) - rust-lang#89794 (Add #[must_use] to to_value conversions) - rust-lang#89814 (Fix uppercase/lowercase error) - rust-lang#89816 (Fix invalid rules in .gitignore) - rust-lang#89817 (Add #[inline] to int log10 functions.) - rust-lang#89818 (Use Option::map_or instead of open coding it) - rust-lang#89828 (Fix config.toml overflow-checks options) - rust-lang#89840 (fix the stage0 tools config file path in `config.toml.example`) - rust-lang#89845 (Add davidtwco to the `.mailmap`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
resolves #52893
resolves #68295
resolves #87750
resolves #88071
All these issues have been fixed according to glacier. Just adding a test so it can be closed.
Can anybody tell me why the github keywords do not work? 🤔
Please edit this post if you can fix it.