Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #89879

Closed
wants to merge 12 commits into from

Commits on Oct 1, 2021

  1. Configuration menu
    Copy the full SHA
    273e522 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Configuration menu
    Copy the full SHA
    9855e7d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Configuration menu
    Copy the full SHA
    c9af192 View commit details
    Browse the repository at this point in the history
  2. Fix line length

    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    2c31c31 View commit details
    Browse the repository at this point in the history
  3. Fix incorrect Box::pin suggestion

    The suggestion checked if Pin<Box<T>> could be coeerced to the expected
    type, but did not check predicates created by the coercion. We now
    look for predicates that definitely cannot be satisfied before giving
    the suggestion.
    
    The suggestion is marked MaybeIncorrect because we allow predicates that
    are still ambiguous and can't be proven.
    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5c14433 View commit details
    Browse the repository at this point in the history
  4. Always check predicates in can_coerce

    This only changed two tests and I consider both changes an improvement.
    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    485ae9f View commit details
    Browse the repository at this point in the history
  5. Move misplaced comment

    tmandry committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    156c922 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a8558e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Rollup merge of rust-lang#89390 - tmandry:issue-72117, r=estebank

    Fix incorrect Box::pin suggestion
    
    The suggestion checked if `Pin<Box<T>>` could be coeerced to the expected
    type, but did not check predicates created by the coercion. We now
    look for predicates that definitely cannot be satisfied before giving
    the suggestion.
    
    The suggestion is still marked MaybeIncorrect because we allow predicates that
    are still ambiguous and can't be proven.
    
    Fixes rust-lang#72117.
    matthiaskrgr authored Oct 14, 2021
    Configuration menu
    Copy the full SHA
    f590a97 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#89433 - arlosi:stdin-fix, r=joshtriplett

    Fix ctrl-c causing reads of stdin to return empty on Windows.
    
    Pressing ctrl+c (or ctrl+break) on Windows caused a blocking read of stdin to unblock and return empty, unlike other platforms which continue to block.
    
    On ctrl-c, `ReadConsoleW` will return success, but also set `LastError` to `ERROR_OPERATION_ABORTED`.
    
    This change detects this case, and re-tries the call to `ReadConsoleW`.
    
    Fixes rust-lang#89177. See issue for further details.
    
    Tested on Windows 7 and Windows 10 with both MSVC and GNU toolchains
    matthiaskrgr authored Oct 14, 2021
    Configuration menu
    Copy the full SHA
    7aca070 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#89823 - jackh726:project-overflow, r=oli-obk

    Switch order of terms to prevent overflow
    
    Fixes rust-lang#89639
    
    r? `@pnkfelix`
    matthiaskrgr authored Oct 14, 2021
    Configuration menu
    Copy the full SHA
    ecc351d View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#89865 - tmandry:llvm-static, r=Mark-Simulacrum

    Allow static linking LLVM with ThinLTO
    
    There's no reason not to allow this if the user wants it. It works, at least in a local build on linux host.
    
    For our use case, we're happy to spend more time building the compiler if it creates a speedup every time we run it, and we've observed speedups like this with clang.
    matthiaskrgr authored Oct 14, 2021
    Configuration menu
    Copy the full SHA
    078372c View commit details
    Browse the repository at this point in the history