Use the "nice E0277 errors"[1] for !Send impl Future from foreign crate
#89889
+73
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
force-pushed
the
unmet-send-bound-on-foreign-future
branch
from
376a759 to
7f4cfa3
Compare
tmandry
approved these changes
Oct 20, 2021
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Show resolved
Hide resolved
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
apiraino
added
the
T-compiler
… crate Partly address rust-lang#78543 by making the error quieter. We don't have access to the `typeck` tables from foreign crates, so we used to completely skip the new code when checking foreign crates. Now, we carry on and don't provide as nice output (we don't clarify *what* is making the `Future: !Send`), but at least we no longer emit a sea of derived obligations in the output. [1]: https://blog.rust-lang.org/inside-rust/2019/10/11/AsyncAwait-Not-Send-Error-Improvements.html
estebank
force-pushed
the
unmet-send-bound-on-foreign-future
branch
from
7f4cfa3 to
6dcff4e
Compare
|
@bors r=tmandry |
|
📌 Commit 6dcff4e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 25, 2021
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#89889 (Use the "nice E0277 errors"[1] for `!Send` `impl Future` from foreign crate) - rust-lang#90127 (Do not mention a reexported item if it's private) - rust-lang#90143 (tidy: Remove submodules from edition exception list) - rust-lang#90238 (Add alias for guillaume.gomez@huawei.com) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly address #78543 by making the error quieter.
We don't have access to the
typecktables from foreign crates, so weused to completely skip the new code when checking foreign crates. Now,
we carry on and don't provide as nice output (we don't clarify what is
making the
Future: !Send), but at least we no longer emit a sea ofderived obligations in the output.
r? @tmandry