clippy::complexity fixes #89943
Merged
clippy::complexity fixes #89943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @oli-obk |
oli-obk
requested changes
Oct 16, 2021
compiler/rustc_expand/src/config.rs
Outdated
| @@ -171,7 +171,7 @@ fn get_features( | |||
| } | |||
|
|
|||
| if let Some(allowed) = sess.opts.debugging_opts.allow_features.as_ref() { | |||
| if allowed.iter().find(|&f| name.as_str() == *f).is_none() { | |||
| if !allowed.iter().any(|f| name.as_str() == *f) { | |||
There was a problem hiding this comment.
I would prefer to move the negation into the closure and use all. Reads more naturally to me
matthiaskrgr
force-pushed
the
clpcompl
branch
from
7f18495 to
c645d3f
Compare
|
@bors r+ rollup |
|
📌 Commit c645d3f has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 16, 2021
clippy::complexity fixes
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#89507 (Add `#[repr(i8)]` to `Ordering`) - rust-lang#89849 (CI: Selecting the Xcode version no longer needed with the macos-11 runners.) - rust-lang#89886 (Update the wasi-libc built with the wasm32-wasi target) - rust-lang#89907 (Remove FIXME since there is nothing to be fixed) - rust-lang#89943 (clippy::complexity fixes) - rust-lang#89953 (Make Option::as_mut const) - rust-lang#89958 (Correct small typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.