Erase late-bound regions before computing vtable debuginfo name. #90050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
michaelwoerister
force-pushed
the
fix-vtable-debug-name-crash-90019
branch
from
0e6c7a2 to
bf39d86
Compare
wesleywiser
approved these changes
Oct 19, 2021
|
@bors r+ |
|
📌 Commit bf39d86 has been approved by |
bors
added
S-waiting-on-bors
wooster0
reviewed
Oct 19, 2021
Co-authored-by: r00ster <r00ster91@protonmail.com>
|
@bors r+ |
|
📌 Commit 5929cf0 has been approved by |
michaelwoerister
added
beta-nominated
|
@bors p=1 Fixes stable-to-beta regression. |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (3d71e74): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
rustbot
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 22, 2021
…ulacrum [beta] backports * Don't emit a warning for empty rmeta files. rust-lang#90072 * Erase late-bound regions before computing vtable debuginfo name. rust-lang#90050 * Fix wrong niche calculation when 2+ niches are placed at the start rust-lang#90040 * Revert rust-lang#86011 to fix an incorrect bound check rust-lang#90025 * Fix macro_rules! duplication when reexported in the same module rust-lang#89867 * Bump cargo to include rust-lang/cargo#9979 - Fix fetching git repos after a force push. r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90019.
The
msvc_enum_fallback()for computing enum type names needs to access the memory layout of niche enums in order to determine the type name.compute_debuginfo_vtable_name()did not properly erase regions before computing type names which made memory layout computation ICE when encountering un-erased regions.r? @wesleywiser