Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not depend on the stored value when trying to cache on disk. #90065

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Do not depend on the stored value when trying to cache on disk. #90065

merged 1 commit into from
Oct 23, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Oct 19, 2021 •
edited
Loading

Having different criteria for loading and saving of query results can lead to saved results that may never be loaded.
Since the on-disk cache is discarded as soon as a compilation error is issued, there should not be any need for an exclusion mecanism based on errors.

As a result, the possibility to condition the storage on the value itself does not appear useful.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 19, 2021
@bors
Copy link
Contributor

bors commented Oct 19, 2021

⌛ Trying commit ac394fd29fd2ff2baabfff4cc8106c4d8fb15610 with merge 6845448cab449904cedade472114984aa6e99168...

@bors
Copy link
Contributor

bors commented Oct 19, 2021

☀️ Try build successful - checks-actions
Build commit: 6845448cab449904cedade472114984aa6e99168 (6845448cab449904cedade472114984aa6e99168)

@rust-timer
Copy link
Collaborator

Queued 6845448cab449904cedade472114984aa6e99168 with parent 1af55d1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6845448cab449904cedade472114984aa6e99168): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 19, 2021
@cjgillot
Copy link
Contributor Author

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2021

📌 Commit ac394fd29fd2ff2baabfff4cc8106c4d8fb15610 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2021
@bors
Copy link
Contributor

bors commented Oct 20, 2021

☔ The latest upstream changes (presumably #89978) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 20, 2021
@cjgillot
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Oct 21, 2021

📌 Commit 0a5666b has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2021
@bors
Copy link
Contributor

bors commented Oct 23, 2021

⌛ Testing commit 0a5666b with merge 55ccbd0...

@bors
Copy link
Contributor

bors commented Oct 23, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 55ccbd0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2021
@bors bors merged commit 55ccbd0 into rust-lang:master Oct 23, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 23, 2021
This was referenced Oct 23, 2021
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (55ccbd0): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@cjgillot cjgillot deleted the novalcache branch October 23, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cjgillot @rust-timer @bors @Mark-Simulacrum @rustbot