Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement coherence checks for negative trait impls #90104

Merged
merged 22 commits into from
Oct 23, 2021
Merged

Implement coherence checks for negative trait impls #90104

merged 22 commits into from
Oct 23, 2021

Commits on Oct 20, 2021

  1. Add polarity to TraitPredicate

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    6975afd View commit details
    Browse the repository at this point in the history

  2. Consider negative polarity on overlap check

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    8b0bfb0 View commit details
    Browse the repository at this point in the history

  3. Consider negative polarity on trait selection

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    ab17068 View commit details
    Browse the repository at this point in the history

  4. Test that if we promise to not impl what would overlap it doesn't act… 

    …ually overlap
    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    511076a View commit details
    Browse the repository at this point in the history

  5. Only assemble_candidates_from_impls for polarity Negative

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    da8873e View commit details
    Browse the repository at this point in the history

  6. Make EvaluationCache consider polarity as cache's key

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    85c8fd9 View commit details
    Browse the repository at this point in the history

  7. Filter out Negative impls on intercrate mode's ambiguous reasoning

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    89a419c View commit details
    Browse the repository at this point in the history

  8. Use predicate_must_hold_modulo_regions

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    6ae1d68 View commit details
    Browse the repository at this point in the history

  9. Filter candidates when goal and impl polarity doesn't match

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    7568632 View commit details
    Browse the repository at this point in the history

  10. Add TraitObligation::polarity() for better encapsulation

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    68d444f View commit details
    Browse the repository at this point in the history

  11. Fix allow_negative_impls logic

    @spastorino
    spastorino committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    5a72753 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Document overlap check filter

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    7829d9d View commit details
    Browse the repository at this point in the history

  2. Document flip polarity

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    c4c76a4 View commit details
    Browse the repository at this point in the history

  3. Move const filter to filter_impls

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    5b5a2e6 View commit details
    Browse the repository at this point in the history

  4. Fix debug method name

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    b03a0df View commit details
    Browse the repository at this point in the history

  5. Fix filter_impls comment

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    2e9fb8b View commit details
    Browse the repository at this point in the history

  6. Add comment about the only way to prove NotImplemented here

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    74454c4 View commit details
    Browse the repository at this point in the history

  7. Add rustc_strict_coherence attribute and use it to check overlap

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    da79fa9 View commit details
    Browse the repository at this point in the history

  8. Assemple trait alias candidates for negative polarity 

    This doesn't work properly yet, we would probably need to implement an
`assembly_neg_candidates` and consider things like `T: !AB` as `T: !A`
|| `T: !B`
    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    132409f View commit details
    Browse the repository at this point in the history

  9. Be sure that we do not allow too much

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    9e26413 View commit details
    Browse the repository at this point in the history

  10. Hide negative coherence checks under negative_impls feature flag

    @spastorino
    spastorino committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    9534186 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. Avoid code duplication by extracting checks into fns

    @spastorino
    spastorino committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    3287f72 View commit details
    Browse the repository at this point in the history