-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect panic/panic_bounds_check
during monomorphization
#90406
Conversation
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
@@ -0,0 +1,58 @@ | |||
// compile-flags:-Zprint-mono-items=eager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the eager mode consider panic
function to be one of roots and hide the bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Good catch!
Thanks @nbdd0121! LGTM.
Is this error correctly caught by lang item check or does |
It'll ICE. But it will ICE regardless this change since |
(with that said this is a very simple check so added it anyway) |
@bors r+ |
📌 Commit 4d619d9 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (db062de): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This would prevent link time errors if these functions are
#[inline]
(e.g. whenpanic_immediate_abort
is used).Fix #90405
Fix rust-lang/cargo#10019
@rustbot label: T-compiler A-codegen